Skip to content

Fix parameters bind #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Aug 8, 2025

Testing the change for #2414

@@ -527,313 +544,313 @@
// covariance

@Override
public ReactiveQuerySqmImpl<R> applyGraph(RootGraph graph, GraphSemantic semantic) {
public ReactiveSqmQueryImpl<R> applyGraph(RootGraph graph, GraphSemantic semantic) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method ReactiveSqmQueryImpl.applyGraph(..) could be confused with overloaded method
applyGraph
, since dispatch depends on static types.
super.setHibernateLockMode( lockMode );
return this;
}

@Override
public ReactiveQuerySqmImpl<R> setTimeout(int timeout) {
public ReactiveSqmQueryImpl<R> setTimeout(int timeout) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method ReactiveSqmQueryImpl.setTimeout(..) could be confused with overloaded method
SqmQueryImpl.setTimeout
, since dispatch depends on static types.
return new MultiTableHandlerBuildResult( multiTableHandler, firstJdbcParameterBindings.get() );
}

public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
GlobalTemporaryTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.
@Override
public CompletionStage<Integer> reactiveExecuteDelete(
SqmDeleteStatement<?> sqmDeleteStatement,
public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
GlobalTemporaryTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.

@Override
public CompletionStage<Integer> reactiveExecuteUpdate(
public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
LocalTemporaryTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.
}

@Override
public CompletionStage<Integer> reactiveExecuteDelete(
public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
LocalTemporaryTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.
@Override
public CompletionStage<Integer> reactiveExecuteUpdate(
SqmUpdateStatement<?> sqmUpdateStatement,
public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PersistentTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.
@Override
public CompletionStage<Integer> reactiveExecuteDelete(
SqmDeleteStatement<?> sqmDeleteStatement,
public MultiTableHandler buildHandler(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PersistentTableMutationStrategy.buildHandler
; it is advisable to add an Override annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants